[no squash] Optimizations and code quality improvements #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
reviewed
Oct 26, 2024
|
Other than what I've commented on, I will apply those suggestions later. |
This eliminates the need of iterating the whole list for every protection operations. Note that the highest index isn't cached, i.e. the first or few (if there are many holes) operations would still suffer from the lag.
Emojigit
force-pushed
the
fork-20241025-optimization
branch
from
f83466e
to
c3c094a
Compare
SmallJoker
reviewed
Oct 27, 2024
Emojigit
force-pushed
the
fork-20241025-optimization
branch
from
c3c094a
to
b54f62e
Compare
SmallJoker
reviewed
Oct 28, 2024
On newer Minetest servers, handles saving jobs in async environment. To prevent conflicts, the save file is locked whie saving, and if a code requests saving while the file is locked, data is saved again immediately after finishing the current save.
startTime is not used anywhere else, so localizing it makes sense and saves memory.
This may add lag, but stops saving entities (which lua_api.md discourages). This also eliminates areas.markPos{1,2} (which seemed to be internal) and integrates areas:setPos{1,2} with such function.
Merges "pos1" and "pos1only" into the same code.
Emojigit
force-pushed
the
fork-20241025-optimization
branch
from
b54f62e
to
a90e4f0
Compare
SmallJoker
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes some parts and improves code quality by following
lua_api.mdrecommendations.Check individual commits for what this PR does and why the changes are made.
For "Prevent saving entities": Due to how
static_save = falseworks, old entities may linger but disappear after punching them or restarting the server again.This PR is ready for review.