Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated hud_elem_type field in main HUD #78

Conversation

Emojigit
Copy link
Member

@Emojigit Emojigit commented Jul 2, 2024

This PR replaces hud_elem_type in the HUD definition with type. This PR is ready for review.

@Niklp09
Copy link
Member

Niklp09 commented Jul 3, 2024

Replacing hud_elem_type w/ type breaks huds on servers running Minetest 5.8.0 and lower. This isn't a problem here since mt uses text if no type is set.

@SmallJoker

This comment was marked as outdated.

@Emojigit
Copy link
Member Author

Emojigit commented Jul 7, 2024

Suggestion: use minetest.get_player_information to determine the field name.

According to the documentation, hud_elem_type is ignored when type is present, so I will keep both.

Done in 767d0e1

hud.lua Outdated Show resolved Hide resolved
hud.lua Outdated Show resolved Hide resolved
Co-authored-by: cx384 <cx384@proton.me>
@Emojigit Emojigit requested review from cx384 and grorp July 10, 2024 22:37
hud.lua Outdated Show resolved Hide resolved
Co-authored-by: cx384 <cx384@proton.me>
@Emojigit Emojigit requested a review from cx384 July 11, 2024 06:28
@SmallJoker SmallJoker merged commit 9024be2 into minetest-mods:master Jul 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants