fix describe model.version.attribute

#326
mindsdb · Jan 10, 2024 · ec67e69 · ec67e69
1 parent 14f6091
commit ec67e69
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/mindsdb_sql/parser/dialects/mindsdb/lexer.py b/mindsdb_sql/parser/dialects/mindsdb/lexer.py
@@ -295,7 +295,7 @@ class MindsDBLexer(Lexer):
     def ID(self, t):
         return t
 
-    @_(r'\d+\.\d*')
+    @_(r'\d+\.\d+')
     def FLOAT(self, t):
         return t
 

diff --git a/tests/test_parser/test_base_sql/test_describe.py b/tests/test_parser/test_base_sql/test_describe.py
@@ -31,3 +31,28 @@ def test_describe_predictor(self):
         assert str(ast) == str(expected_ast)
         assert ast.to_tree() == expected_ast.to_tree()
 
+        # describe attr
+        sql = "DESCRIBE MODEL pred.attr"
+        ast = parse_sql(sql, dialect='mindsdb')
+
+        expected_ast = Describe(type='predictor', value=Identifier(parts=['pred', 'attr']))
+
+        assert str(ast) == str(expected_ast)
+
+        # version
+        sql = "DESCRIBE MODEL pred.11"
+        ast = parse_sql(sql, dialect='mindsdb')
+
+        expected_ast = Describe(type='predictor', value=Identifier(parts=['pred', '11']))
+
+        assert str(ast) == str(expected_ast)
+
+        # version and attr
+        sql = "DESCRIBE MODEL pred.11.attr"
+        ast = parse_sql(sql, dialect='mindsdb')
+
+        expected_ast = Describe(type='predictor', value=Identifier(parts=['pred', '11', 'attr']))
+
+        assert str(ast) == str(expected_ast)
+
+