Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement BuildDataSourceRegistry in data sources service #5050

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

JAORMX
Copy link
Contributor

@JAORMX JAORMX commented Nov 25, 2024

Summary

This implements the aforementioned missing function.

Fixes #5048

Change Type

Mark the type of change your PR introduces:

  • Bug fix (resolves an issue without affecting existing features)
  • Feature (adds new functionality without breaking changes)
  • Breaking change (may impact existing functionalities or require documentation updates)
  • Documentation (updates or additions to documentation)
  • Refactoring or test improvements (no bug fixes or new functionality)

Testing

Outline how the changes were tested, including steps to reproduce and any relevant configurations.
Attach screenshots if helpful.

Review Checklist:

  • Reviewed my own code for quality and clarity.
  • Added comments to complex or tricky code sections.
  • Updated any affected documentation.
  • Included tests that validate the fix or feature.
  • Checked that related changes are merged.

This implements the aforementioned missing function.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
@JAORMX JAORMX marked this pull request as ready for review November 26, 2024 07:55
@JAORMX JAORMX requested a review from a team as a code owner November 26, 2024 07:55
@coveralls
Copy link

Coverage Status

coverage: 54.605% (+0.2%) from 54.42%
when pulling a3cb677 on JAORMX:BuildDataSourceRegistry-ds
into 43d02cd on mindersec:main.

@JAORMX JAORMX merged commit 7cc4969 into mindersec:main Nov 26, 2024
25 checks passed
@JAORMX JAORMX deleted the BuildDataSourceRegistry-ds branch November 26, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data source service: Implement BuildDataSourceRegistry
3 participants