Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] rename char classifiation scripts and dependency pin #1469

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

felixdittrich92
Copy link
Contributor

This PR:

  • as discussed rename character classification training scripts (change also corresponding docs)
  • remove old result csv files
  • pin tf to <2.16 (Keras v3) ([TensorFlow] Upgrade to keras v3 #1461)
  • upper bound from hf-hub (1.0.0)

Any feedback is welcome 🤗

@felixdittrich92 felixdittrich92 added topic: build Related to dependencies and build ext: references Related to references folder topic: character classification Related to the task of character classification type: misc Miscellaneous labels Feb 13, 2024
@felixdittrich92 felixdittrich92 added this to the 0.8.0 milestone Feb 13, 2024
@felixdittrich92 felixdittrich92 self-assigned this Feb 13, 2024
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ff5ce2) 95.83% compared to head (4c9b66e) 95.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1469      +/-   ##
==========================================
- Coverage   95.83%   95.82%   -0.02%     
==========================================
  Files         162      162              
  Lines        7112     7112              
==========================================
- Hits         6816     6815       -1     
- Misses        296      297       +1     
Flag Coverage Δ
unittests 95.82% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@odulcy-mindee odulcy-mindee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @felixdittrich92 !

@felixdittrich92 felixdittrich92 merged commit 2daf0d9 into mindee:main Feb 14, 2024
69 of 70 checks passed
@felixdittrich92 felixdittrich92 deleted the rename-and-misc branch February 14, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: references Related to references folder topic: build Related to dependencies and build topic: character classification Related to the task of character classification type: misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants