Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TensorFlow] Upgrade to keras v3 #1461

Open
felixdittrich92 opened this issue Feb 9, 2024 · 0 comments
Open

[TensorFlow] Upgrade to keras v3 #1461

felixdittrich92 opened this issue Feb 9, 2024 · 0 comments
Assignees
@felixdittrich92
Labels
framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models type: breaking change Introducing a breaking change
Milestone
1.0.0

Comments

@felixdittrich92
Copy link
Contributor

felixdittrich92 commented Feb 9, 2024 •
edited
Loading

🚀 The feature

TensorFlow >= 2.16.0 switches to Keras v3 (keras-core) which will especially break the saving and loading logic from models in our case

  • pin to >=TF 2.16.0 (requires py3.9 min)

Keras: https://keras.io/api/models/model_saving_apis/weights_saving_and_loading/#save_weights-method
tf2onnx: https://github.com/onnx/tensorflow-onnx?tab=readme-ov-file#from_keras-tf-20-and-newer
hf hub: https://huggingface.co/docs/huggingface_hub/guides/upload

(Optional) Provide a script to convert old models to new format
@felixdittrich92 felixdittrich92 added module: models Related to doctr.models type: breaking change Introducing a breaking change framework: tensorflow Related to TensorFlow backend labels Feb 9, 2024
@felixdittrich92 felixdittrich92 added this to the 1.0.0 milestone Feb 9, 2024
@felixdittrich92 felixdittrich92 self-assigned this Feb 9, 2024
@felixdittrich92 felixdittrich92 mentioned this issue Feb 13, 2024
Merged
@odulcy-mindee odulcy-mindee mentioned this issue Apr 18, 2024
Merged
@felixdittrich92 felixdittrich92 mentioned this issue Jun 6, 2024
Closed
@felixdittrich92 felixdittrich92 mentioned this issue Sep 9, 2024
Closed
@felixdittrich92 felixdittrich92 mentioned this issue Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felixdittrich92 felixdittrich92

Labels
framework: tensorflow Related to TensorFlow backend module: models Related to doctr.models type: breaking change Introducing a breaking change
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@felixdittrich92