Change how cover accessories are handled to match observed behavior o… #618
Conversation
…f real hardware. prettier
| this.updateValue(data, callback); | ||
| }) | ||
| .catch(this.accessory.handleError("GET", callback)); | ||
| this.updateValue({}, callback); |
There was a problem hiding this comment.
It looks like we are now no longer fetching the remote state 🤔
What would happen if you use another system (outside of homekit) to update the state?
It seems like homekit wouldn't update with the new state.
There was a problem hiding this comment.
Yes, could be, but I'm not into the code. It is just the PR from bSr43/homebridge-tuya-web@91ef52e you asked for.
Maybe you can combine the code? Would be awesome!
Is there a way we can donate for your work?
|
AFAIK, these type of RF cover devices do not provide feedback to HomeKit. But once they are in sync, they work fine for automations and such. If they ever get out of sync, they have to be adjusted. |
Tuya is the creator of many different appliances; not all devices that are considered "cover devices" are RF; The non-RF devices should be able to report their state back, that also what the current implementation was built for. |
|
Thank you. That makes sense. I’m very interested in the Issue with Zemismart Cover RF devices getting stuck showing opening/closing or not reacting unless the command is sent two or three times. It’s interesting that Zigbee2MQTT has the same issue with Zemismart Cover RF devices. I’m not sure how the Fork in question solves this problem. Maybe the RF USB Stick “goes to sleep” or something. The logs do not show any data on the first “click”. |
|
I've got a QUOYA MC11 Blind, opens/closes via Homekit fine, but Homekit always says "opening" or "closing". Just in case that is of any use towards working out this PR. |
|
This patch fixes plugin behaviour for my Avatto blinds controller which has an RF remote. Without this patch, my blinds are stuck on opening or closing state forever. The delay until the state is reported as fully Open or Closed could be reduced in my case. I was running bSr43's years old fork of this plugin because it contains this patch, but that plugin recently stopped working completely so I switched to milo526's version with this PR applied. If it's unclear whether this patch breaks things for some users, perhaps the behaviour to automatically report state as Open or Closed after a while could be a config option? |
…f real hardware.
prettier