Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OADP-2144: Resize cloned pvc based on cmp between cloned vs size and source pvc size #251

Merged
merged 7 commits into from
Aug 28, 2023
Merged

OADP-2144: Resize cloned pvc based on cmp between cloned vs size and source pvc size #251

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e591b33
reszie cloned pvc based on cmp between cloned vs size and source pvc …
shubham-pampattiwar Jul 7, 2023
14c6b86
minor update
shubham-pampattiwar Jul 7, 2023
e6d01c5
harden the logic to resize
shubham-pampattiwar Jul 17, 2023
60ee167
use VSC size instead of VS
shubham-pampattiwar Aug 1, 2023
0c27093
minor fix
shubham-pampattiwar Aug 1, 2023
edc96c1
set cloned PVC storage request from clone VSC restoreSize
shubham-pampattiwar Aug 3, 2023
19e0982
remove cu patch log statements
shubham-pampattiwar Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions controllers/pvc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,19 @@ func (r *VolumeSnapshotBackupReconciler) buildPVCClone(pvcClone *corev1.Persiste
return err
}

// check the size of source pvc with that of the cloned volumesnapshot
// The cloned pvc provisioning will fail if the source pvc spec.resources.requests.sotrage value is less than the volumesnapshot.status.restorSize value
// In order to tackle this problem we compare both the values and use the one that is maximum so that provisioning of cloned pvc does not fail
// currently we are keeping this pvc resizing a default behavior but this can be put behind a datamover feature boolean flag

clonedVSRestoreSize := vsClone.Status.RestoreSize.Size()
sourcePVCRequestSize := sourcePVC.Spec.Resources.Size()

clonedPVCSize := sourcePVCRequestSize
if clonedVSRestoreSize > sourcePVCRequestSize {
clonedPVCSize = clonedVSRestoreSize
}

if pvcClone.CreationTimestamp.IsZero() {
apiGroup := "snapshot.storage.k8s.io"
pvcClone.Spec.DataSource = &corev1.TypedLocalObjectReference{
Expand Down Expand Up @@ -143,6 +156,11 @@ func (r *VolumeSnapshotBackupReconciler) buildPVCClone(pvcClone *corev1.Persiste
}

pvcClone.Spec.Resources = sourcePVC.Spec.Resources

// use the clonedPVCSize that is computed earlier
if clonedPVCSize != sourcePVCRequestSize {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just always set to clonedSize?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawn-hurley will cloned size ever be smaller than source PVC size? This seems safer for "just in case the (almost) impossible happens"

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no right? https://github.com/migtools/volume-snapshot-mover/pull/251/files#diff-f62131094710ef63a76f5e484071a4e7254ff8a2d176f0957e2dd677495eff04R117-R120

We are just doing the same logic twice I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sseago @shawn-hurley updated the PR, PTAL, Thanks !

pvcClone.Spec.Resources.Requests.Storage().Set(int64(clonedPVCSize))
}
}

return nil
Expand Down