Fix: If a single image gen breaks, that should not break the whole thing

middlewarehq · Dec 12, 2023 · 07b5e11 · 07b5e11
1 parent ac5a161
commit 07b5e11
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/api-helpers/image-gen.ts b/src/api-helpers/image-gen.ts
@@ -25,11 +25,11 @@ export const generateImages = async (
         createImageUsingVercel(
           { ...adaptedData[cardName], username: data.user.login },
           cardName
-        )
+        ).catch(() => null)
       )
     );
 
-    return imageFileBuffers;
+    return imageFileBuffers.filter(Boolean) as ImageFile[];
   } catch (error) {
     console.error('Error in generateImages:', error);
     logException('Error in generateImages', { originalException: error });

diff --git a/src/api-helpers/vercel-generator.tsx b/src/api-helpers/vercel-generator.tsx
@@ -42,7 +42,7 @@ export const createImageUsingVercel = async (
     try {
       imageArrayBuffer = await generatedImage.arrayBuffer();
     } catch (error) {
-      logException('Error converting image to array buffer for ${cardType}', {
+      logException(`Error converting image to array buffer for ${cardType}`, {
         originalException: error
       });
       throw new Error(`Image buffer creation failed for ${cardType}`);