Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TechNobo.TcNoAccountSwitcher version 4 #126209

Conversation

Eddga
Copy link
Contributor

@Eddga Eddga commented Nov 12, 2023

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.5 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Eddga
Copy link
Contributor Author

Eddga commented Nov 12, 2023

This is the same program version as in #125068 but #125068 is missing some dependencies and also contains the wrong package version. Even though the release should have the version 5.0 2023-07-05 (which is the actual github release version) or something alike it installs as version 4 on Windows. This would lead to it never being the most current version when checked against with winget list --upgrade-available
I tried to submit this using the replace parameter. But that didn't work as expected (already opened #478).
Please remove/revert #125068 when merging this PR.

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed Possible-Duplicate labels Nov 12, 2023
@wingetbot
Copy link
Collaborator

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: 0080e116f43a86642c58e0fb57bf912035c1e25f9a16b4e9d7559cf26e502f94
    • manifests\t\TechNobo\TcNoAccountSwitcher\2023-07-05_00

@stephengillie
Copy link
Collaborator

stephengillie commented Nov 16, 2023

Hi @Eddga,

This package appears to already be in the repository. Should the InstallerUrl be different? Currently its path includes the version number mentioned in the error.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Nov 16, 2023
@Eddga
Copy link
Contributor Author

Eddga commented Nov 19, 2023

Hi @Eddga,

This package appears to already be in the repository. Should the InstallerUrl be different? Currently its path includes the version number mentioned in the error.

Hi @stephengillie,
The InstallerURL is correct and yes the package IS already in the repository.
But the issue is that the app installs as version 4:
image
So it's a bug of the program using the wrong uninstall string: TCNOco/TcNo-Acc-Switcher#355
Therefore the existing manifest needs to be replaced. Otherwise the app will always be detected as update available.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 19, 2023
@stephengillie stephengillie removed Possible-Duplicate Needs-Attention This work item needs to be reviewed by a member of the core team. labels Dec 1, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 50c92bf into microsoft:master Dec 1, 2023
7 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Dec 1, 2023
@stephengillie
Copy link
Collaborator

Sorry for the delay.

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@Eddga Eddga deleted the TechNobo.TcNoAccountSwitcher-4-89b15d90-cfaf-4398-8568-4427a8397539 branch December 5, 2023 18:58
@Eddga
Copy link
Contributor Author

Eddga commented Dec 5, 2023

Sorry for the delay.

No worries, mate! Thanks a lot for all the time and effort you put in this project! 🙂👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants