Reload pom contents as needed before finding parent POMs (#1022)

microsoft · Jan 31, 2024 · 8ee1ef0 · 8ee1ef0
1 parent 9305308
commit 8ee1ef0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/src/archetype/createProject/SelectParentPomStep.ts b/src/archetype/createProject/SelectParentPomStep.ts
@@ -19,7 +19,16 @@ export class SelectParentPom implements IProjectCreationStep {
             }
         ];
         MavenProjectManager.projects
-            .filter(project => project.artifactId && project.pomPath && pathExistsSync(project.pomPath))
+            .filter(project => project.pomPath && pathExistsSync(project.pomPath))
+            .map(project => {
+                if (!project.artifactId) {
+                    // reload pom contents
+                    project.parsePom();
+                }
+
+                return project;
+            })
+            .filter(project => project.artifactId && project.groupId)
             .sort((a, b) => a.pomPath.length - b.pomPath.length)
             .forEach(project => {
                 items.push({

diff --git a/src/project/MavenProjectManager.ts b/src/project/MavenProjectManager.ts
@@ -59,7 +59,9 @@ export class MavenProjectManager {
     }
 
     public static add(pomPath: string): void {
-        MavenProjectManager.getInstance()._projectMap.set(pomPath, new MavenProject(pomPath));
+        const newProject = new MavenProject(pomPath);
+        newProject.parsePom();
+        MavenProjectManager.getInstance()._projectMap.set(pomPath, newProject);
     }
 
     public static remove(pomPath: string): void {