Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Halide] Fix download url #42282

Merged
merged 33 commits into from
Nov 25, 2024
Merged

[Halide] Fix download url #42282

merged 33 commits into from
Nov 25, 2024

Conversation

FrankXie05
Copy link
Contributor

Fix #42269

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@FrankXie05 FrankXie05 added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 21, 2024
LilyWangLL
LilyWangLL previously approved these changes Nov 21, 2024
View reviewed changes
@FrankXie05 FrankXie05 marked this pull request as ready for review November 22, 2024 01:19
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Nov 22, 2024
@BillyONeal BillyONeal merged commit 2bf7865 into microsoft:master Nov 25, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks!

@FrankXie05 FrankXie05 deleted the dev/Frank/42269 branch November 26, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@BillyONeal BillyONeal BillyONeal left review comments

@LilyWangLL LilyWangLL LilyWangLL left review comments

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[halide] Build error on x64-windows
4 participants
@FrankXie05 @BillyONeal @dg0yt @LilyWangLL