Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "maybe" operations to JSON. #1520

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

BillyONeal
Copy link
Member

Extracted from #1514

This avoids some check/confirm anti-patterns and discourages null-dereference prone code like *example.get(). Example:

job.insert(JsonIdId, Json::Value::string(*args.github_run_id.get()));

@BillyONeal BillyONeal merged commit 829b20e into microsoft:main Oct 23, 2024
6 checks passed
@BillyONeal BillyONeal deleted the json-maybe-operations branch October 23, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants