-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move vcpkgTools.xml into the tool and better support for arm64-linux #1490
base: main
Are you sure you want to change the base?
Conversation
…ting trivial destruction.
…the search loop, and get rid of magic numbers that is the length of the table.
Hm I would prefer if the vcpkg-tool would get the data via a json file. With a separate file it would be easy to workaround if one of the domains is offline or otherwise broken, to replace an url with an internal version or to test a new version of a tool. |
Make the table be static data, deduplicate part of the expression in the search loop, and get rid of magic numbers that is the length of the table.
Especially updating CMake requires testing with a world rebuild before merging it. +1 on the json part since vcpkg already knows how to parse json. But yeah you are just transforming a tools.xml to a tools.json |
Extracted from microsoft#1490 as it's unclear when that change will land.
Extracted from #1490 as it's unclear when that change will land.
This PR contains several changes:
vcpkgTools.xml
data into the tool. This will remove ourXML
regex parsing logic, and make it easier to add logic on what tools to install on which platforms.Related: #1277
Followup PRs:
Ninja does not support arm64 linux on vcpkg's current version. I will be making a PR to update Ninja and add architecture support for arm64 linux.