Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add and link libcurl #1422

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

add and link libcurl #1422

wants to merge 10 commits into from

Conversation

Neumann-A
Copy link
Contributor

@Neumann-A Neumann-A commented Jun 10, 2024

Hmmm somebody said they need vcpkg to link libcurl directly instead of using curl. So here is an example how to implement that. (#1043)

cmake/FindLibCURL.cmake Outdated Show resolved Hide resolved
cmake/FindLibCURL.cmake Outdated Show resolved Hide resolved
Co-authored-by: Osyotr <Osyotr@users.noreply.github.com>
@Neumann-A
Copy link
Contributor Author

Neumann-A commented Jun 10, 2024

Don't quite understand why recv is unavailable in linux CI.
Nevermind -Werror broke all the stuff

@BillyONeal
Copy link
Member

I think assuming libcurl.so will work is 'safe' on *nix?

My main concern with this is accidentally embedding 'which OpenSSL are you using' assumptions into our binaries, but we should be able to use the system's bundled libcurl.so as a firewall for this.

@BillyONeal
Copy link
Member

(That is to say, on Windows, static link libcurl and use schannel backend, and rip out all the WinHTTP stuff. On non-Windows, use the system's libcurl.so. Then we can statically link the real Azure Storage SDKs to get sane uploads of >5TB. Does that seem reasonable to you?)

@Neumann-A
Copy link
Contributor Author

@BillyONeal: Feel free to edit. I just made this PR to enable others who want to explorer this way. Probably just replace option(VCPKG_DEPENDENCY_EXTERNAL_LIBCURL "Use an external version of the libcurl library" OFF) with a platform dependent ON/OFF. use schannel backend don't know the option for it but it is probably in the portfile of curl somewhere.

Does that seem reasonable to you?

hmm maybe? I honestly have no clue what you are talking about. As I said, I just made this PR to enable others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants