-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add and link libcurl #1422
base: main
Are you sure you want to change the base?
add and link libcurl #1422
Conversation
Co-authored-by: Osyotr <Osyotr@users.noreply.github.com>
|
I think assuming libcurl.so will work is 'safe' on *nix? My main concern with this is accidentally embedding 'which OpenSSL are you using' assumptions into our binaries, but we should be able to use the system's bundled |
(That is to say, on Windows, static link libcurl and use schannel backend, and rip out all the WinHTTP stuff. On non-Windows, use the system's libcurl.so. Then we can statically link the real Azure Storage SDKs to get sane uploads of >5TB. Does that seem reasonable to you?) |
@BillyONeal: Feel free to edit. I just made this PR to enable others who want to explorer this way. Probably just replace
hmm maybe? I honestly have no clue what you are talking about. As I said, I just made this PR to enable others. |
Hmmm somebody said they need vcpkg to link libcurl directly instead of using curl. So here is an example how to implement that. (#1043)