Move most of git out of VcpkgPaths #1381
Conversation
Thomas1664
changed the title
There was a problem hiding this comment.
I agree that it would be better if the git stuff were disconnected from VcpkgPaths, but the git stuff is hard to test and risky to change, so we probably need a design description of what this kind of refactoring is going to achieve before we can seriously evaluate making this change to the product.
Refactoring changes need to be justified by:
- the end they're trying to reach resulting in user facing product improvements, or
- the kinds of changes they are enabling making easier (or such changes are 'obvious')
Without that they're adding risk to the product, by changing the product, for no benefit.
Notably, this change leaves the 'nexus' of getting to git in vcpkgpaths, since the entry point is still VcpkgPaths::git_cmd_builder or similar, so I'm not sure of the end it's trying to reach.
| auto init_registries_git_dir = git_cmd_builder(config).string_arg("init"); | ||
| auto maybe_init_output = flatten(cmd_execute_and_capture_output(init_registries_git_dir), Tools::GIT); | ||
| if (!maybe_init_output) |
There was a problem hiding this comment.
This function does not appear to be well described either if it's potentially doing init.
No description provided.