Skip to content

Commit

Permalink
Temporarily disable GitHub telemetry. (#1131)
Browse files Browse the repository at this point in the history
The vcpkg team is interested in having an idea of how many vcpkg users there are. Unfortunately, ephemeral CI systems will make a new machine every build or something like that, which can make one user look like hundreds of users. To help reduce that problem, in #1113 @dan-shaw added reporting of GitHub IDs so that we may deduplicate all CI runs for a project as one 'user'. Unfortunately, there was a miscommunication and privacy folks want to look more closely to make sure that nothing about these IDs might be PII. (We only care about the number of users, not who those users are.)

Our understanding is that these IDs are in fact not PII, and after confirmation we'll turn this back on.
  • Loading branch information
BillyONeal authored Jul 17, 2023
1 parent 6d98eb5 commit e266a5a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/vcpkg/vcpkgcmdarguments.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -700,6 +700,7 @@ namespace vcpkg
submission.track_string(StringMetric::DetectedCiEnvironment, *ci_env);
}

#if 0 // CI system telemetry pending privacy review
if (auto repo_id = github_repository_id.get())
{
submission.track_string(StringMetric::CiProjectId, *repo_id);
Expand All @@ -709,6 +710,7 @@ namespace vcpkg
{
submission.track_string(StringMetric::CiOwnerId, *owner_id);
}
#endif // ^^^ telemetry disabled

get_global_metrics_collector().track_submission(std::move(submission));
}
Expand Down

0 comments on commit e266a5a

Please sign in to comment.