Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add devcontainer for examples #49

Merged
merged 9 commits into from
Feb 2, 2024
Merged

feat: add devcontainer for examples #49

merged 9 commits into from
Feb 2, 2024

Conversation

ydaponte
Copy link
Collaborator

Adding devcontainer to the repository to avoid environment problems when running the framework.
Instructions on usage are included in the ReadMe.md

Addressing issue #48

@ydaponte ydaponte added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 21, 2023
@ydaponte ydaponte self-assigned this Dec 21, 2023
@ydaponte ydaponte changed the title Add dev container capability to the repo Add dev container capability to the repo - for examples folder Dec 22, 2023
arjendev
arjendev reviewed Dec 22, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
arjendev
arjendev reviewed Dec 22, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
arjendev
arjendev reviewed Dec 22, 2023
View reviewed changes
examples/README.md Outdated Show resolved Hide resolved
arjendev
arjendev reviewed Dec 22, 2023
View reviewed changes
examples/README.md Outdated Show resolved Hide resolved
arjendev
arjendev reviewed Dec 22, 2023
View reviewed changes
examples/README.md Outdated Show resolved Hide resolved
arjendev
arjendev requested changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@arjendev arjendev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yennifer, this will help people getting started quite well. I have added a bunch of comments. Let's call if there's anything unclear or if you don't agree with some comments :)

@ydaponte ydaponte added this to the 2023-12 milestone Dec 22, 2023
@ydaponte ydaponte changed the title Add dev container capability to the repo - for examples folder feat: add devcontainer for examples Jan 25, 2024
arjendev
arjendev previously approved these changes Feb 2, 2024
View reviewed changes
@ydaponte ydaponte merged commit 7f6fae5 into main Feb 2, 2024
4 checks passed
@ydaponte ydaponte deleted the ydaponte/add-dev-container branch March 27, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjendev arjendev arjendev approved these changes

Assignees

@ydaponte ydaponte

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Azure Data Factory Testing Framework
Status: Done
Milestone
2023-12
Development

Successfully merging this pull request may close these issues.
2 participants
@ydaponte @arjendev