Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce TestFramework class to evaluate child executePipeline… #21

Merged
merged 6 commits into from
Nov 6, 2023
Merged

feat: introduce TestFramework class to evaluate child executePipeline… #21

merged 6 commits into from
Nov 6, 2023

Conversation

arjendev
Copy link
Collaborator

@arjendev arjendev commented Oct 4, 2023 •
edited
Loading

This PR introduces:

  • The TestFramework class which will be responsible for managing repositories and evaluation of pipelines, linkedServices, datasets and triggers.
  • The DataFactoryRepository class which will parse the entire data-factory folder.
  • Evaluation of child-pipelines (ExecutePipelineActivity) if enabled in the TestFramework constructor.

@arjendev arjendev force-pushed the arjendev/execute-child-pipelines branch 2 times, most recently from 2dfd2e3 to 90fc8ca Compare October 4, 2023 14:16
@arjendev arjendev force-pushed the arjendev/execute-child-pipelines branch from 90fc8ca to ba190ba Compare October 4, 2023 14:24
@ydaponte ydaponte added the enhancement New feature or request label Oct 16, 2023
@ydaponte ydaponte added this to the 2023-10 milestone Oct 16, 2023
@ydaponte ydaponte self-requested a review October 16, 2023 09:48
ydaponte
ydaponte previously approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@ydaponte ydaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments, not blocking the PR. You can go ahead and merge.
Just in the PR itself, when you create the PR link it to the issue you are solving. In this case add something like " PR closes issue #7 ". We might need to create a PR template with a checklist.

src/AzureDataFactory.TestingFramework.Example/BatchJob/BatchJobUnitTests.cs Show resolved Hide resolved
src/AzureDataFactory.TestingFramework/AzureDataFactory.TestingFramework.csproj Show resolved Hide resolved
src/AzureDataFactory.TestingFramework/Models/Pipelines/Pipeline.cs Outdated Show resolved Hide resolved
@arjendev arjendev force-pushed the arjendev/execute-child-pipelines branch from e8e7279 to bc7e5c7 Compare November 6, 2023 10:00
@arjendev arjendev linked an issue Nov 6, 2023 that may be closed by this pull request
Evaluate child pipelines #7
Closed
@arjendev
Copy link
Collaborator Author

arjendev commented Nov 6, 2023

Just minor comments, not blocking the PR. You can go ahead and merge. Just in the PR itself, when you create the PR link it to the issue you are solving. In this case add something like " PR closes issue #7 ". We might need to create a PR template with a checklist.

I referenced the issue in the PR now (not in text but as part of the PR).

ydaponte
ydaponte approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@ydaponte ydaponte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! Thanks!

@arjendev arjendev merged commit 6048e79 into main Nov 6, 2023
2 checks passed
@arjendev arjendev deleted the arjendev/execute-child-pipelines branch December 24, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ydaponte ydaponte ydaponte approved these changes

Assignees

@arjendev arjendev

Labels
enhancement New feature or request
Projects
Azure Data Factory Testing Framework
Status: Done
Milestone
2023-10
Development

Successfully merging this pull request may close these issues.

Evaluate child pipelines
2 participants
@arjendev @ydaponte