Added error handling. #1607
Open
Added error handling. #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karkarl
reviewed
Aug 15, 2024
WinUIGallery/App.xaml.cs
Outdated
| @@ -24,6 +24,7 @@ | |||
| using System.Text; | |||
| using Windows.System; | |||
| using System.Runtime.InteropServices; | |||
| using Microsoft.Toolkit.Uwp.Notifications; | |||
There was a problem hiding this comment.
Would you be able to use the WinAppSDK Notifications instead from the Community Toolkit?
|
/azp run |
karkarl
reviewed
Nov 13, 2024
WinUIGallery/WinUIGallery.csproj
Outdated
| @@ -83,6 +83,30 @@ | |||
| <AppxBundle>Never</AppxBundle> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug-Unpackaged|x86'" /> | |||
There was a problem hiding this comment.
Are changes here intentional? If so, what is it for?
There was a problem hiding this comment.
Are changes here intentional? If so, what is it for?
Fixed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an unhandled exception gets thrown the app no longer crashes. Now the user gets a notification with the exception.
Description
Motivation and Context
The app crashes a lot.
How Has This Been Tested?
While testing I added a button that throws an exception to test my code.
Screenshots:
Types of changes