This repository has been archived by the owner on Jan 12, 2024. It is now read-only.
Refactoring improved adder implementation #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 26, 2020 15:23
guenp
reviewed
Oct 28, 2020
| CCNOT (carryIn, summand2, carryOut); | ||
| CCNOT(summand1, summand2, carryOut); | ||
| CNOT(summand1, summand2); | ||
| CCNOT(carryIn, summand2, carryOut); | ||
| } | ||
|
|
||
| /// # Summary | ||
| /// Implements a compute carry gate using a temporary logical-AND construction. |
There was a problem hiding this comment.
Is this related to figure 1 in this paper (https://arxiv.org/pdf/1709.06648.pdf)? If yes could we link it here?
There was a problem hiding this comment.
This operation is not related to that paper. It has been used in the previous implementation, and only remains in the code, because it has been exposed as public API. It basically computes the majority-of-three function out-of-place into carryOut, but also changes the state of summand2.
There was a problem hiding this comment.
Ok thanks! Is there another reference we can link here?
guenp
reviewed
Nov 5, 2020
guenp
reviewed
Nov 5, 2020
msoeken
commented
Nov 5, 2020
msoeken
commented
Nov 5, 2020
Co-authored-by: Guen P <guenp@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs refactors the recent changes by @TviNet in #358 to address #335.
With these changes the operations
CarryandSumare no longer needed inside the Standard library, but have been exposed as public API, and therefore cannot be removed.