Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolate on DevHomeAzureExtension namespace #230

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Conversation

krschau
Copy link
Collaborator

@krschau krschau commented Jun 26, 2024

Summary of the pull request

Pulling out part of #229 to just do namespace changes and keep that PR smaller.
As @dkbennett wrote, "The default when creating a new class is AzureExtension namespace after the directory, but we actually use DevHomeAzureExtension namespace name with a shorter directory name to help reduce potential max-path issues. Some components were created using the default AzureExtension namespace and this was fixed."

References and relevant issues

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

@krschau krschau added this to the DHAE v0.11 milestone Jun 26, 2024
@krschau krschau mentioned this pull request Jun 26, 2024
@krschau krschau merged commit fe77336 into main Jun 26, 2024
3 checks passed
@krschau krschau deleted the user/krschau/namespace branch June 26, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants