Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added package name & version to HTTP headers #201

Merged
merged 3 commits into from
Jun 5, 2024
Merged

Conversation

huzaifa-d
Copy link
Contributor

Summary of the pull request

This adds the package name and version to all HTTP request headers, in the form of UserAgent, sent to Dev Box APIs. This will facilitate easier telemetry for them.

Validation steps performed

Verified with the Dev Box team to make sure the requests received now had a distinct header.

PR checklist

Copy link
Contributor

@bbonaby bbonaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick question, do you happen to know if Package.Current.Id.Name has whether its canary/dev in the name?

@huzaifa-d
Copy link
Contributor Author

Quick question, do you happen to know if Package.Current.Id.Name has whether its canary/dev in the name?

@bbonaby I do, and it does, for example - Microsoft.Windows.DevHomeAzureExtension.Dev

@huzaifa-d huzaifa-d merged commit bf09745 into main Jun 5, 2024
3 checks passed
@huzaifa-d huzaifa-d deleted the user/modanish/Header branch June 20, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants