Skip to content

Commit

Permalink
Added ToDo comments; Emptied constructor
Browse files Browse the repository at this point in the history
  • Loading branch information
huzaifa-d committed Nov 28, 2023
1 parent 568eede commit 1d64ace
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions src/AzureExtension/DevBox/DevBoxInstance.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@ public DevBoxInstance(IDevBoxAuthService devBoxAuthService)
// Returns a DevBox object from a JSON object
public void FillFromJson(JsonElement item, string project, IDeveloperId? devId) => throw new NotImplementedException();

// ToDo: Use System.Uri
private (string WebURI, string RdpURI) GetRemoteLaunchURIsAsync(string boxURI)
{
return (string.Empty, string.Empty);
Expand Down
4 changes: 2 additions & 2 deletions src/AzureExtension/DevBox/DevBoxProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,8 @@ public class DevBoxProvider : IComputeSystemProvider, IDisposable
{
private readonly IHost _host;

public DevBoxProvider(IHost host)
public DevBoxProvider()
{
_host = host;
}

string IComputeSystemProvider.DefaultComputeSystemProperties
Expand Down Expand Up @@ -50,6 +49,7 @@ public IEnumerable<IComputeSystem> GetComputeSystemsAsync(IDeveloperId? develope
}
else
{
// ToDo: Remove throw and add to return object
Log.Logger()?.ReportError($"Error getting systems: Rest Service not configured");
throw new ArgumentException($"Rest Service needs to be configured.");
}
Expand Down

0 comments on commit 1d64ace

Please sign in to comment.