BPA Rule Updates #247
Open
BPA Rule Updates #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to description of "Provide format string for Date columns
Handle empty files. For example, an empty DAX Query View file.
|
I noticed an error on Import-FabricItem and Import-FabricItems with the following error: Exception calling "ToBase64String" with "1" argument(s): "Value cannot be null. (Parameter 'inArray')" This can occur if someone saves a pbip file with an empty DAX Query View file. I added a ternary operator to check fileContent is not null before trying to call the "ToBase64String" function. |
kerski
changed the title
added 2 commits
May 1, 2024 12:35
Handle empty files. For example, an empty DAX Query View file.
kerski
changed the title
added 2 commits
May 1, 2024 12:38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the INTEGER_FORMATTING rule was falsely identifying Date-based DAX measures against this rule.
Also description for Provide format string for "Date" and "Month" column rules had the same description. I fixed the description to reference the correct name.