Improved examples with adding usage of DataLoader #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sorry for pushing you guys, @marceloverdijk @sdelamo @graemerocher @ilopmar , do you have time to take a look at this PR? Is there anything that I need to fix or improve? |
|
This looks ok to me. Thoughts @marceloverdijk ? |
|
Yes this looks good! |
marceloverdijk
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this PR can close this issue: #41. I have a little bit improved current todo examples and added examples of how to use DataLoader with plain
graphql-javaand alsographql-java-toolsas well. Sorry, I haven't improvedspqrexample, because never use this tool before, I'm pretty sure there must be a way how to use data loaders with spqr, but I'm not familiar with it. If someone wants to improve that example as well, please check this issue: leangen/graphql-spqr#182, it looks like there is an answer on how to do it inside.