svelte-device-info #1050
Open
svelte-device-info #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pineapplemachine
requested changes
Nov 5, 2021
.gitignore
Outdated
| @@ -3,3 +3,4 @@ npm-debug.log | |||
| .DS_Store | |||
| .idea | |||
| microjs.com.iml | |||
| package-lock.json | |||
There was a problem hiding this comment.
Please only change data.js when adding a library. Please do not change .gitignore.
| tags: ["mobile", "phone","tablet","form-factor","resolution-touch"], | ||
| description: "informs about a device's form factor and pointing accuracy (not only in Svelte)", | ||
| url: "https://github.com/rozek/svelte-device-info", | ||
| source: "https://raw.githubusercontent.com/rozek/svelte-device-info/main/src/svelte-device-info.ts" |
There was a problem hiding this comment.
From the readme - emphasis on "ready-to-use", which means you should not link to a TypeScript source file:
The 'source' attribute must point to a single-file, or an array of files that can be concatenated to form your complete library in a ready-to-use form. The 'source' must not be minified (see below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"svelte-device-info" informs about a device's form factor and pointing accuracy (not only in Svelte)