Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade LMS to 8.5.2, Squeezelite to 2.0.0-1488+git20240509.0e85ddf-1.1 #743

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

rtertiaer
Copy link
Contributor

What does this change intend to accomplish?

This PR upgrades LMS to 8.5.2, and Squeezelite to 2.0.0-1488+git20240509.0e85ddf-1.1. This is a bit of a Hail Mary for #702 . I backported a source squeezelite from upstream trixie and compiled according to our instructions; the LMS .deb comes from the project upstream.

Filing this as a draft right now, because I'm running this on gramplipi at least overnight to ensure stability.

Checklist

  • Have you tested your changes and ensured they work?
  • If applicable, have you updated the CHANGELOG?

@rtertiaer
Copy link
Contributor Author

I ran this overnight and it worked well. I'm gonna make an alpha release with this + the support tunnel in it and get feedback from one of our users who is interested in both and we have active communication with.

@rtertiaer rtertiaer marked this pull request as ready for review June 11, 2024 18:20
@@ -157,17 +157,17 @@
]
},
'lms' : {
'apt': ['libcrypt-openssl-rsa-perl', 'libio-socket-ssl-perl'], # needed for ShairTunes2W support
'apt': ['libcrypt-openssl-rsa-perl', 'libio-socket-ssl-perl', 'libopusfile0'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

squeezelite has this dep but we're installing using dpkg, which does not do dependencies. #472 would obviate this need (and frankly save a lot of disk IO, upgrade time, compiling time elsewhere, etc...)

@rtertiaer rtertiaer marked this pull request as draft June 18, 2024 14:34
@rtertiaer rtertiaer marked this pull request as draft June 18, 2024 14:34
@rtertiaer
Copy link
Contributor Author

This has run for 7+ days on Gramplipi, streaming constantly, with seemingly zero issues. I'm going to test some of the plugins quickly on babyboy, but otherwise mark this as a requested change.

@rtertiaer
Copy link
Contributor Author

In addition to an internet radio station, I tested Pyrrha, Spotty & TiDAL plugins, and they all worked out of the box.

@rtertiaer rtertiaer marked this pull request as ready for review June 18, 2024 15:06
Copy link
Contributor

@linknum23 linknum23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tried out Pyrra.

@rtertiaer rtertiaer merged commit 22af5f9 into main Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants