-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag for 'exact match' #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The exact_match
part of this PR is good.
We would prefer that next time the commenting/documentation gets added in another PR, preferably one with an issue attached.
For more details, see the review comments.
Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
Co-authored-by: classabbyamp <5366828+classabbyamp@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks for you feedback. Accepted your suggestions
Description
A Flag called 'exact_match' was added. Now it can be checked, if a call needs to match exactly to apply the data.
Fixes #42
Type of change
How has this been tested?
China: 24: 44: AS: 36.00: -102.00: -8.0: BY:
3H,3H0(23)[42],=B7/BA7CK(26),=BD9BI/0(23)[42]
Fed. Rep. of Germany: 14: 28: EU: 51.00: -10.00: -1.0: DL:
=DR9Z/LH;
Results in:
'entity': 'Fed. Rep. of Germany', 'cq': 14, 'itu': 28, 'continent': 'EU', 'lat': 51.0, 'long': -10.0, 'tz': 1.0, 'len': 2, 'primary_pfx': 'DL', 'exact_match': False}
{'entity': 'Fed. Rep. of Germany', 'cq': 14, 'itu': 28, 'continent': 'EU', 'lat': 51.0, 'long': -10.0, 'tz': 1.0, 'len': 2, 'primary_pfx': 'DL', 'exact_match': True}
{'entity': 'China', 'cq': 24, 'itu': 44, 'continent': 'AS', 'lat': 36.0, 'long': -102.0, 'tz': 8.0, 'len': 2, 'primary_pfx': 'BY', 'exact_match': False}
{'entity': 'China', 'cq': 24, 'itu': 44, 'continent': 'AS', 'lat': 36.0, 'long': -102.0, 'tz': 8.0, 'len': 2, 'primary_pfx': 'BY', 'exact_match': False}
{'entity': 'China', 'cq': 23, 'itu': 42, 'continent': 'AS', 'lat': 36.0, 'long': -102.0, 'tz': 8.0, 'len': 2, 'primary_pfx': 'BY', 'exact_match': False}
{'entity': 'China', 'cq': 26, 'itu': 44, 'continent': 'AS', 'lat': 36.0, 'long': -102.0, 'tz': 8.0, 'len': 2, 'primary_pfx': 'BY', 'exact_match': True}
{'entity': 'China', 'cq': 23, 'itu': 42, 'continent': 'AS', 'lat': 36.0, 'long': -102.0, 'tz': 8.0, 'len': 2, 'primary_pfx': 'BY', 'exact_match': True}
Checklist
DEVELOPING.md
, if it exists)CHANGELOG.md
updated if needed