Setup PHP CS Fixer #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmichalski
force-pushed
the
cs-fixer
branch
from
4671093
to
a11b380
Compare
marmichalski
commented
Dec 20, 2023
| @@ -40,6 +40,10 @@ jobs: | |||
| with: | |||
| dependency-versions: "${{ matrix.dependencies }}" | |||
|
|
|||
| - name: "Check code style" | |||
| if: ${{ matrix.dependencies == 'highest' && matrix.php == '8.1' }} | |||
There was a problem hiding this comment.
This should essentially just run on locked dependencies (same for psalm), but we don't run CI with locked deps, maybe we should?
mgrajcarek
previously approved these changes
Dec 20, 2023
|
@marmichalski could you resolve conflicts? |
marmichalski
dismissed
mgrajcarek’s stale review
The merge-base changed after approval.
marmichalski
force-pushed
the
cs-fixer
branch
from
a11b380
to
1a36b18
Compare
it is done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an old .php_cs file, but it was not made part of CI checks, so let's introduce cs fixer shim and run it in CI 🙈