Use charmbracelet/lipgloss and remove tablewriter #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
changed the title
|
I'm curious if you checked the consequence on the binary size (because of the imports changes) I would recommend using @Zxilly I'm curious about the results. I could check myself, but I'm on phone for the weekend. And well, "give a man a fish…" 😁 |
|
It went down a bit. v0.15.0 - 4.1M |
|
Great then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #135
Opened a non-blocking issue upstream, charmbracelet/lipgloss#424. I took a quick look to see if there's something we can do with https://github.com/charmbracelet/glamour, but didn't see an easy way to get interoperability from a lipgloss table to a glamour markdown table (likely it's outside the scope).