-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test name text wrapping on small screens #124
Conversation
Mind jotting down a before/after example? |
I don't get it. The only thing that changed is a test file. The PR talks about adding a argument to tparse |
@ccoVeille This is not a go test file. It's one of the app files. @mfridman Sure. |
My bad, indeed the name |
internal/app/table_tests.go
Outdated
testName.WriteString(" /") | ||
for len(s) > maxLength { | ||
testName.WriteString(s[:maxLength] + "\n ") | ||
s = s[maxLength:] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend adding an ellipsis then. Either an Unicode character (my preference) or a three successive dots
s = s[maxLength:] | |
s = s[maxLength:]+"…" |
Good Idea! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for contributing!
This PR enables -smallscreen arg to wrap the name of the test if it's too long.