Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golangci-lint-action #119

Merged
merged 4 commits into from
May 6, 2024
Merged

Add golangci-lint-action #119

merged 4 commits into from
May 6, 2024

Conversation

mfridman
Copy link
Owner

@mfridman mfridman commented May 6, 2024

This PR picks up from #118 and adds golangci-lint-action as a GH lint workflow.

@@ -13,15 +13,15 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go-version: ['1.20', '1.21', '1.22']
go-version: ['1.21', '1.22']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use 'oldstable', 'stable' if you want, so you never have to update them

https://github.com/marketplace/actions/setup-go-environment#using-stableoldstable-aliases

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in fb13b85 for consistency.

@mfridman mfridman merged commit 6ab1958 into main May 6, 2024
3 checks passed
@mfridman mfridman deleted the mf/golangci-in-ci branch May 6, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants