Call enhancer, carpool events #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 27, 2024 10:12
Co-authored-by: Frank Gerhardt <fg@gerhardt.io>
|
@frsaba double check that all commits are in PR 34 and then remove this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call to enhancer: with the enhancer separated to another FastAPI service, whenever a carpool is changed, a background task is created that calls the enhancer configured in
enhancer_urland saves the new carpool to data/enhanced.The Amarillo docker image has been separated into a base and a derived image. The base image only contains Amarillo with no plugins, while the derived image has the plugins included. This way plugins can be more easily interchanged/updated without recreating the entire image, and different deployments can use a different set of plugins with the same underlying base image.
Carpool event hook system: plugins can now register callbacks to be run when a carpool is created/updated/deleted, e.g the metrics plugin uses it to count the number of carpool changes with all of the necessary code encapsulated in the plugin itself. More events can be added later.