This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes things quite a bit in order to support chunked inserts/updates:
Quick benchmark on a set of 27280 files (mainly FLAC & MP3s):
With this patch, from scratch, added in 8:03 minutes, without added in 9:59 , time is mainly spent reading audio file metadata.
A second scan (no change), is done in 9s with this patch and in 19s without this patch.
A second benchmark, using a set of 4926 mp3 files:
First scan is done in 12 seconds with this patch, 33 seconds without. Gain with MP3 files is more obvious since reading metadata from those is faster (files are much smaller).
Second scan (no change), 2 seconds with this patch, 4 seconds without.