Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Rob's Xmas present to himself: Hacking on the content resolver #13

Merged
merged 42 commits into from
Jan 10, 2024

Conversation

mayhem
Copy link
Member

@mayhem mayhem commented Jan 10, 2024

This PR was originally supposed to add one new element to the LB radio support and instead it ended up being a huge PR that adds a pile of new features.

All of this is new code with no real users yet, so please review this lightly, looking for obvious problems. The real testing and debugging is about to start once I get more people using this code.

mayhem and others added 30 commits December 24, 2023 12:39
This adds compatibility with clients not supporting getAlbumInfo2
subsonic: fix wrong variable use to read album name and artist
@mayhem mayhem requested a review from amCap1712 January 10, 2024 11:36
Copy link
Member

@amCap1712 amCap1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a quick look, LGTM!

@mayhem mayhem merged commit 8ab77dd into main Jan 10, 2024
6 checks passed
@massdosage
Copy link
Collaborator

Let me know if there is anything here that would benefit being run over my monster audio collection ;)

Also, should we set up GH to by default tick the box to delete the branch on merge so we don't have dangling branches that are already in main?

@mayhem
Copy link
Member Author

mayhem commented Jan 10, 2024

@massdosage : Yes, please. I would love to know what you think of the period-jams or lb-radio features here. That should be quite fun against your collection, methinks. And yes, let me tick that box.

@mayhem mayhem deleted the add-artist-element branch January 10, 2024 16:23
@mayhem
Copy link
Member Author

mayhem commented Jan 10, 2024

Branches cleaned up and stray PR opened.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants