This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 5
Rob's Xmas present to himself: Hacking on the content resolver #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds compatibility with clients not supporting getAlbumInfo2
Subsonic fixes
subsonic: fix wrong variable use to read album name and artist
amCap1712
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick look, LGTM!
Let me know if there is anything here that would benefit being run over my monster audio collection ;) Also, should we set up GH to by default tick the box to delete the branch on merge so we don't have dangling branches that are already in |
@massdosage : Yes, please. I would love to know what you think of the period-jams or lb-radio features here. That should be quite fun against your collection, methinks. And yes, let me tick that box. |
Branches cleaned up and stray PR opened. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was originally supposed to add one new element to the LB radio support and instead it ended up being a huge PR that adds a pile of new features.
All of this is new code with no real users yet, so please review this lightly, looking for obvious problems. The real testing and debugging is about to start once I get more people using this code.