This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsonic changes:
getAlbumList2
instead ofgetAlbumList
. This fetches albums by tags, not by directory structure, and I think this is better supported. E.g. Navidrome supports both, butgetAlbumList
uses fake directories based on tags. And Funkwhale only supportsgetAlbumList2
album["name"]
instead ofalbum["album"]
for the name. While some clients return both the Subsonic docs only mentionname
as the keygetAlbumInfo2
if the release MBID was already returned by the calls togetAlbumList2
orgetAlbum
. This avoids an API call and makes things compatible ifgetAlbumList2
is not supported (e.g. Funkwhale).With these changes the subsonic command becomes compatible with Funkwhale with my patch for OpenSubsonic at https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2695 applied