Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

Subsonic fixes #10

Merged
merged 2 commits into from
Dec 31, 2023
Merged

Conversation

phw
Copy link
Member

@phw phw commented Dec 31, 2023

Subsonic changes:

  • Use getAlbumList2 instead of getAlbumList. This fetches albums by tags, not by directory structure, and I think this is better supported. E.g. Navidrome supports both, but getAlbumList uses fake directories based on tags. And Funkwhale only supports getAlbumList2
  • Use album["name"] instead of album["album"] for the name. While some clients return both the Subsonic docs only mention name as the key
  • Avoid the call to getAlbumInfo2 if the release MBID was already returned by the calls to getAlbumList2 or getAlbum. This avoids an API call and makes things compatible if getAlbumList2 is not supported (e.g. Funkwhale).

With these changes the subsonic command becomes compatible with Funkwhale with my patch for OpenSubsonic at https://dev.funkwhale.audio/funkwhale/funkwhale/-/merge_requests/2695 applied

Copy link
Member

@mayhem mayhem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mayhem mayhem merged commit 9f38115 into metabrainz:add-artist-element Dec 31, 2023
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants