Merge pull request #14 from zas/missing_discnumber

Do not raise an exception when disc number is missing, defaults to 0
metabrainz · Jan 10, 2024 · fb7b82d · fb7b82d
2 parents 8ab77dd + e4d5817
commit fb7b82d
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/lb_content_resolver/formats/flac.py b/lb_content_resolver/formats/flac.py
@@ -19,7 +19,7 @@ def read(file):
     mdata["release_name"] = get_tag_value(tags, "album")
     mdata["recording_name"] = get_tag_value(tags, "title")
     mdata["track_num"] = extract_track_number(get_tag_value(tags, "tracknumber"))
-    mdata["disc_num"] = int(get_tag_value(tags, "discnumber"))
+    mdata["disc_num"] = int(get_tag_value(tags, "discnumber") or 1)
     mdata["artist_mbid"] = get_tag_value(tags, "musicbrainz_artistid")
     mdata["recording_mbid"] = get_tag_value(tags, "musicbrainz_trackid")
     mdata["release_mbid"] = get_tag_value(tags, "musicbrainz_albumid")

diff --git a/lb_content_resolver/formats/mp3.py b/lb_content_resolver/formats/mp3.py
@@ -45,7 +45,7 @@ def read(file):
     if "TPOS" in tags:
         mdata["disc_num"] = extract_track_number(str(tags["TPOS"]))
     else:
-        mdata["disc_num"] = 0
+        mdata["disc_num"] = 1
 
     if "TXXX:MusicBrainz Artist Id" in tags:
         id = str(tags["TXXX:MusicBrainz Artist Id"])

diff --git a/lb_content_resolver/formats/ogg_opus.py b/lb_content_resolver/formats/ogg_opus.py
@@ -19,7 +19,7 @@ def read(file):
     mdata["release_name"] = get_tag_value(tags, "album")
     mdata["recording_name"] = get_tag_value(tags, "title")
     mdata["track_num"] = extract_track_number(get_tag_value(tags, "tracknumber"))
-    mdata["disc_num"] = int(get_tag_value(tags, "discnumber"))
+    mdata["disc_num"] = int(get_tag_value(tags, "discnumber") or 1)
     mdata["artist_mbid"] = get_tag_value(tags, "musicbrainz_artistid", "")
     mdata["recording_mbid"] = get_tag_value(tags, "musicbrainz_trackid", "")
     mdata["release_mbid"] = get_tag_value(tags, "musicbrainz_albumid", "")

diff --git a/lb_content_resolver/formats/ogg_vorbis.py b/lb_content_resolver/formats/ogg_vorbis.py
@@ -19,7 +19,7 @@ def read(file):
     mdata["release_name"] = get_tag_value(tags, "album")
     mdata["recording_name"] = get_tag_value(tags, "title")
     mdata["track_num"] = extract_track_number(get_tag_value(tags, "tracknumber"))
-    mdata["disc_num"] = int(get_tag_value(tags, "discnumber"))
+    mdata["disc_num"] = int(get_tag_value(tags, "discnumber") or 1)
     mdata["artist_mbid"] = get_tag_value(tags, "musicbrainz_artistid", "")
     mdata["recording_mbid"] = get_tag_value(tags, "musicbrainz_trackid", "")
     mdata["release_mbid"] = get_tag_value(tags, "musicbrainz_albumid", "")

diff --git a/lb_content_resolver/formats/wma.py b/lb_content_resolver/formats/wma.py
@@ -19,7 +19,7 @@ def read(file):
     mdata["release_name"] = str(get_tag_value(tags, "WM/AlbumTitle"))
     mdata["recording_name"] = str(get_tag_value(tags, "Title"))
     mdata["track_num"] = extract_track_number(str(get_tag_value(tags, "WM/TrackNumber")))
-    mdata["disc_num"] = int(get_tag_value(tags, "WM/SetSubTitle"))
+    mdata["disc_num"] = int(get_tag_value(tags, "WM/SetSubTitle") or 1)
     mdata["artist_mbid"] = str(get_tag_value(tags, "MusicBrainz/Artist Id"))
     mdata["recording_mbid"] = str(get_tag_value(tags, "MusicBrainz/Release Track Id"))
     mdata["release_mbid"] = str(get_tag_value(tags, "MusicBrainz/Album Id"))