Replace C-style term type integer checks with TermType enum #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You probably just need to update the |
|
I rebuilt spoofax-libs.jar. This change looked trivial and built locally without any issues, which is why I thought it didn't need review. Would this be okay to merge? |
Apanatshka
approved these changes
Jul 15, 2020
| import org.spoofax.interpreter.terms.IStrategoTerm; | ||
| import org.spoofax.terms.util.NotImplementedException; | ||
| import org.strategoxt.lang.Context; | ||
| import org.strategoxt.lang.Strategy; | ||
| import org.strategoxt.lang.compat.StringValuePrimitive; |
There was a problem hiding this comment.
This looks unrelated to the PR. But I don't really care very much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depended on:
Apparently Stratego XT needs to be bootstrapped first before it knows about
TermType.