Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#186] - delete topics from CLI #245

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[#186] - delete topics from CLI #245

wants to merge 2 commits into from

Conversation

clehene
Copy link

@clehene clehene commented Aug 3, 2016

  • Bumped version (shouldn't this be done after each release?)
  • Added delete capability

@deric
Copy link

deric commented Aug 15, 2016

👍

liorze
liorze reviewed Aug 24, 2016
View reviewed changes
README.md
# curl "http://localhost:7000/api/topic/delete?topic=t"
{"topic" : {"name" : "t", "partitions" : {"0" : "0, 1"}, "options" : {}}}
```

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think DELETE is more appropriate here than a GET to /delete endpoint

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@liorze I agree, however I made this consistent with the rest of the code (remove broker) which uses GET for the removal operation as well. Changing to proper HTTP DELETE operations it's, hence a change of the current API which is outside of the scope of this issue IMO.

@steveniemitz
Copy link
Contributor

This is an awesome patch, do you think you could rebase it and I'll merge it in? I can take a crack at rebasing it too if you don't have time.

@clehene
Copy link
Author

clehene commented Jan 26, 2017

@steveniemitz I'll attempt a rebase hopefully tomorrow

plaflamme added a commit to plaflamme/kafka that referenced this pull request Jun 13, 2017
@plaflamme
Delete topic from cli.
5546118 
Closes mesos#186 also based on mesos#245
plaflamme added a commit to plaflamme/kafka that referenced this pull request Jun 13, 2017
@plaflamme
Delete topic from cli.
6a4fedc 
Closes mesos#186 also based on mesos#245
plaflamme added a commit to plaflamme/kafka that referenced this pull request Jun 13, 2017
@plaflamme
Delete topic from cli.
c10dffc 
Closes mesos#186 also based on mesos#245
plaflamme added a commit to plaflamme/kafka that referenced this pull request Jun 13, 2017
@plaflamme
Delete topic from CLI.
e8ea077 
Closes mesos#186 also based on mesos#245
plaflamme added a commit to plaflamme/kafka that referenced this pull request Jun 13, 2017
@plaflamme
Delete topic from CLI.
74c3334 
Closes mesos#186. Inspired by mesos#245
@plaflamme plaflamme mentioned this pull request Jun 13, 2017
Merged
plaflamme added a commit to plaflamme/kafka that referenced this pull request Jun 13, 2017
@plaflamme
Delete topic from CLI.
a955cce 
Closes mesos#186. Inspired by mesos#245
plaflamme added a commit to plaflamme/kafka that referenced this pull request Jun 13, 2017
@plaflamme
Delete topic from CLI.
3a20ea7 
Closes mesos#186. Inspired by mesos#245
steveniemitz pushed a commit that referenced this pull request Jun 14, 2017
@plaflamme @steveniemitz
Delete topic from CLI. (#307)
70e91ee 
* Delete topic from CLI.

Closes #186. Inspired by #245

* Use FormParam instead of BothParam.

* Adds unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clehene @deric @steveniemitz @liorze