Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create schema/mike #51

Merged
merged 31 commits into from
Oct 27, 2023
Merged

Create schema/mike #51

merged 31 commits into from
Oct 27, 2023

Conversation

Mike47ip
Copy link
Collaborator

@Mike47ip Mike47ip commented Oct 26, 2023 •
edited
Loading

  • Create a schema.sql file with tables that will be analogical to the structure of the classes that you created:
    books table (add all properties and associations from the parent Item class as table columns)
    labels table

@Mike47ip
Create music_album class
6933356
@Mike47ip
Create music_list
84e0500
@Mike47ip
Create music.json
798525f
@Mike47ip
Move music_list to modules folder
a8d6bfb
@Mike47ip
Edit album_recovery
f35de8a
@Mike47ip
Add attr_accessor to App
6246f8d
@Mike47ip
Innitialize albums ang genres
3acfa26
@Mike47ip
Create music list method
5072889
@Mike47ip
Create addJ_ music method
01ba7cc
@Mike47ip
Incorporate music_album into app.rb
71b25c5
@Mike47ip
Create genre.rb
07a988c
@Mike47ip
Fix all eroors in app.rb
134e57f
@Mike47ip
Engage rubocop
1dc73a2
@Mike47ip
Toggle LF
1541620
@Mike47ip
Disable end of line sequence
b22c037
@Mike47ip
Merge branch 'dev' into feature/music_genre/mike
a3c33dc
@Mike47ip
Disable ClassLength Max
7cd210b
@Mike47ip
Merge branch 'feature/music_genre/mike' of https://github.com/mershar…
b436d85 
…k/ruby-group-capstone into feature/music_genre/mike
@Mike47ip
Test app with Mike and Evans code
215b7f1
@Mike47ip
Set parent class attribute to default emply strings to avoid subclass…
1dedf57 
… args errors
@Mike47ip
Create test for music album
5e08e7e
@Mike47ip
Create test for genre
718424d
@Mike47ip
Solve music album expected args errors
b1e4f7e
@Mike47ip
Test app in console
a78cad2
@Mike47ip
Toggle LF
c06a33f
@Mike47ip
Export json storage methods into modules
5b9aebf
@Mike47ip
Create to_h method
4fa4771
@Mike47ip
Create music-album.sql
6b7973a
@Mike47ip
Toggle LF
d22718a
@Mike47ip
Resove conflicts
ebfc9eb
This was linked to issues Oct 26, 2023
[1pt][Team member #2] Create MusicAlbum class in a separate .rb file. #19
Closed
[1pt][Team member #2]Create Genre class with an association to the Item class (in a separate .rb file). #22
Closed
[1pt][Team member #2] All MusicAlbum class properties visible in the diagram should be defined and set up in the constructor method. #24
Closed
[1pt][Team member #2] All Genre class properties visible in the diagram should be defined and set up in the constructor method #26
Closed
[1pt] [Team member #2] Implement methods #27
Closed
[1pt][Team member #2] Add unit tests for all implemented methods. #28
Closed
[1pt][Team member #2]The following options should be available: #29
Closed
[1pt][Team member #2]Create a schema.sql file with tables that will be analogical to the structure of the classes that you created #30
Closed
[1pt][Team member #2]All data should be preserved by saving collections in .json files. #31
Closed
mershark
mershark approved these changes Oct 26, 2023
View reviewed changes
Copy link
Owner

@mershark mershark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🟢 🟢
Your project is complete! There is nothing else to say other than... it's time to merge it.
Congratulations! 🎉

prg-04
prg-04 approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@prg-04 prg-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🟢 🟢
Your project is complete! There is nothing else to say other than... it's time to merge it.
Congratulations! 🎉

fatmahussein
fatmahussein approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@fatmahussein fatmahussein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 🟢 🟢
Your project is complete! There is nothing else to say other than... it's time to merge it.
Congratulations! 🎉

@Mike47ip Mike47ip merged commit 2331b22 into dev Oct 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mershark mershark mershark approved these changes

@prg-04 prg-04 prg-04 approved these changes

@fatmahussein fatmahussein fatmahussein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1pt] [Team member #2] Implement methods [1pt][Team member #2] All Genre class properties visible in the diagram should be defined and set up in the constructor method [1pt][Team member #2] All MusicAlbum class properties visible in the diagram should be defined and set up in the constructor method. [1pt][Team member #2]Create Genre class with an association to the Item class (in a separate .rb file). [1pt][Team member #2] Create MusicAlbum class in a separate .rb file.
[1pt][Team member #2] Add unit tests for all implemented methods. [1pt][Team member #2]The following options should be available: [1pt][Team member #2]Create a schema.sql file with tables that will be analogical to the structure of the classes that you created [1pt][Team member #2]All data should be preserved by saving collections in .json files.
4 participants
@Mike47ip @fatmahussein @prg-04 @mershark