cache secplus_v2 message halves for when we dont get both in a single transmission #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is modelled on the secplus_v1 handling, where messages are kept and timestamped so they can be reassembled over a longer time period. this makes the button presses from a Merlin M970E appear as fully decoded messages. the M970E operates around 433MHz. not sure if that matters.
|
IIRC there is another PR with these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is modelled on the secplus_v1 handling, where messages are kept and timestamped so they can be assembled over a longer time period.
This makes the button presses from a Merlin M970E appear as fully decoded messages. The M970E operates around 433MHz, unlike other devices that this driver supports which look like they operate at 310MHz. Not sure if that matters.
I did this quickly, there is probably more elegant tweaks to the code that could have been made.