Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix series freeze impl #166

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Fix series freeze impl #166

merged 2 commits into from
Apr 24, 2024

Conversation

sritchie
Copy link
Member

@sritchie sritchie commented Apr 18, 2024

  • Fix series freeze impl #166 fixes a broken freeze implementation for series. Before this fix,
    sin-series and cos-series printed as these two strings, respectively:

    "(+ (expt _ 0) (* (/ -1 6) (expt _ 1)) ...)"
    "(+ (expt _ 0) (* (/ -1 2) (expt _ 1)) ...)"

    this happened because zeros were dropped and then all remaining coefficients
    were zipped with x^0, x^1 etc.

    These now print correctly as

    "(+ (expt _ 1) (* (/ -1 6) (expt _ 3)) ...)"
    "(+ (expt _ 0) (* (/ -1 2) (expt _ 2)) ...)"

Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.71%. Comparing base (d354463) to head (0d43257).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
+ Coverage   87.68%   87.71%   +0.03%     
==========================================
  Files          99       99              
  Lines       15862    15863       +1     
  Branches      853      852       -1     
==========================================
+ Hits        13908    13914       +6     
+ Misses       1101     1097       -4     
+ Partials      853      852       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sritchie sritchie marked this pull request as ready for review April 23, 2024 22:21
@sritchie sritchie merged commit f3ac544 into main Apr 24, 2024
6 checks passed
@sritchie sritchie deleted the sritchie/series_fix branch April 24, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants