Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dual number + tape implementations? #161

Closed
wants to merge 14 commits into from
Closed

Conversation

sritchie
Copy link
Member

@sritchie sritchie commented Apr 9, 2024

It turns out we can accumulate forward-mode as we go in the forward pass of reverse mode... adding this here since it works, AND it confuses me!!

@sritchie sritchie changed the base branch from main to sritchie/nested April 9, 2024 17:44
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 86.25954% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 87.31%. Comparing base (556cc83) to head (d3a16ba).

Files Patch % Lines
src/emmy/tape.cljc 84.94% 11 Missing and 3 partials ⚠️
src/emmy/calculus/derivative.cljc 81.81% 1 Missing and 1 partial ⚠️
src/emmy/abstract/function.cljc 91.66% 1 Missing ⚠️
src/emmy/series.cljc 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           sritchie/nested     #161      +/-   ##
===================================================
- Coverage            87.46%   87.31%   -0.16%     
===================================================
  Files                  100      100              
  Lines                16100    16188      +88     
  Branches               860      866       +6     
===================================================
+ Hits                 14082    14134      +52     
- Misses                1158     1188      +30     
- Partials               860      866       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sritchie sritchie changed the base branch from sritchie/nested to main April 15, 2024 12:57
@sritchie sritchie closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant