Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use FS-specific listdir in folder tap #2785

Merged
merged 6 commits into from
Nov 30, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 30, 2024

Copy link

codspeed-hq bot commented Nov 30, 2024

CodSpeed Performance Report

Merging #2785 will not alter performance

Comparing edgarrmondragon/fix/listdir-folder-tap (3fbe4c1) with main (3ad4615)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Nov 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (3ad4615) to head (3fbe4c1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2785      +/-   ##
==========================================
+ Coverage   90.88%   91.02%   +0.13%     
==========================================
  Files          62       62              
  Lines        5170     5170              
  Branches      667      666       -1     
==========================================
+ Hits         4699     4706       +7     
+ Misses        330      326       -4     
+ Partials      141      138       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon added this to the v0.43 milestone Nov 30, 2024
@edgarrmondragon edgarrmondragon self-assigned this Nov 30, 2024
@edgarrmondragon edgarrmondragon added the Type/Tap Singer taps label Nov 30, 2024
@edgarrmondragon edgarrmondragon merged commit 7fd95e3 into main Nov 30, 2024
36 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/listdir-folder-tap branch November 30, 2024 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type/Tap Singer taps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant