feat(taps): Numeric values are now parsed as decimal.Decimal
in REST and GraphQL stream responses
#2780
+44
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means under normal circumstances,
decimal.Decimal
would be used across the board:"value": 3.14
in the API response is parsed asDecimal("3.14")
Decimal("3.14")
value is serialized to JSON asvalue: 3.14
in the tap output"value": 3.14
in theRECORD
Singer message will be parsed asDecimal("3.14")
by the target.That should ensure we preserve precision through the pipeline.
Caution
Now, this could be a breaking change if folks are doing floating-point math with these values, but I think it's rare enough that we can make do with a call-out in the release notes.
📚 Documentation preview 📚: https://meltano-sdk--2780.org.readthedocs.build/en/2780/