-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support other content-types in REST streams #2762
Merged
edgarrmondragon
merged 4 commits into
main
from
2761-feat-support-other-content-types-for-http-streams
Nov 14, 2024
Merged
feat: Support other content-types in REST streams #2762
edgarrmondragon
merged 4 commits into
main
from
2761-feat-support-other-content-types-for-http-streams
Nov 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2762 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2762 +/- ##
==========================================
+ Coverage 90.74% 90.80% +0.05%
==========================================
Files 62 62
Lines 5102 5122 +20
Branches 659 660 +1
==========================================
+ Hits 4630 4651 +21
Misses 330 330
+ Partials 142 141 -1 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
2761-feat-support-other-content-types-for-http-streams
branch
from
November 13, 2024 05:51
b4d7d0a
to
f829f74
Compare
edgarrmondragon
force-pushed
the
2761-feat-support-other-content-types-for-http-streams
branch
from
November 14, 2024 01:41
f829f74
to
ee6fbc9
Compare
edgarrmondragon
changed the title
WIP: Support other content-types for HTTP streams
WIP: Support other content-types in REST streams
Nov 14, 2024
edgarrmondragon
changed the title
WIP: Support other content-types in REST streams
feat: Support other content-types in REST streams
Nov 14, 2024
edgarrmondragon
added
Release Highlight
Call this out in the release notes
Type/Tap
Singer taps
labels
Nov 14, 2024
edgarrmondragon
deleted the
2761-feat-support-other-content-types-for-http-streams
branch
November 14, 2024 03:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated docs:
RESTStream.payload_as_json
RESTStream.rest_method
RESTStream.http_method
Related:
📚 Documentation preview 📚: https://meltano-sdk--2762.org.readthedocs.build/en/2762/