Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Safely compare UUID replication keys with state bookmarks #2755

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

nikzavada
Copy link
Contributor

@nikzavada nikzavada commented Nov 11, 2024

This change will return a stringified value for an instance of uuid.UUID.


📚 Documentation preview 📚: https://meltano-sdk--2755.org.readthedocs.build/en/2755/

@nikzavada nikzavada changed the title Add a branch to to_json_compatible to return a stringified value for uuid.UUID fix: Add a branch to to_json_compatible to return a stringified value for uuid.UUID Nov 11, 2024
Copy link

codspeed-hq bot commented Nov 11, 2024

CodSpeed Performance Report

Merging #2755 will not alter performance

Comparing nikzavada:patch-1 (ec5bf31) with main (ae7516b)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.74%. Comparing base (ae7516b) to head (ec5bf31).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2755   +/-   ##
=======================================
  Coverage   90.74%   90.74%           
=======================================
  Files          62       62           
  Lines        5099     5102    +3     
  Branches      658      659    +1     
=======================================
+ Hits         4627     4630    +3     
  Misses        330      330           
  Partials      142      142           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon changed the title fix: Add a branch to to_json_compatible to return a stringified value for uuid.UUID fix: Safely compare UUID replication keys with state bookmarks Nov 11, 2024
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nikzavada!

@edgarrmondragon edgarrmondragon added this pull request to the merge queue Nov 11, 2024
Merged via the queue into meltano:main with commit 42eff70 Nov 11, 2024
31 checks passed
@edgarrmondragon edgarrmondragon self-assigned this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants