-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added SQLConnector.prepare_primary_key
for target to implement for custom table primary key adaptation
#2730
Merged
edgarrmondragon
merged 6 commits into
main
from
2729-feat-extend-the-sql-connector-api-to-support-adapting-to-primary-key-changes
Oct 22, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
added
Needs Documentation
Release Highlight
Call this out in the release notes
labels
Oct 21, 2024
CodSpeed Performance ReportMerging #2730 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2730 +/- ##
=======================================
Coverage 90.70% 90.71%
=======================================
Files 62 62
Lines 5016 5021 +5
Branches 641 641
=======================================
+ Hits 4550 4555 +5
Misses 325 325
Partials 141 141 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
force-pushed
the
2729-feat-extend-the-sql-connector-api-to-support-adapting-to-primary-key-changes
branch
from
October 21, 2024 18:26
3fe8ed0
to
4dab2f3
Compare
…pport-adapting-to-primary-key-changes
edgarrmondragon
changed the title
feat: Added
feat: Added Oct 22, 2024
SQLConnector.prepare_primary_key
SQLConnector.prepare_primary_key
for target to implement for custom table primary Key adaptation
edgarrmondragon
changed the title
feat: Added
feat: Added Oct 22, 2024
SQLConnector.prepare_primary_key
for target to implement for custom table primary Key adaptationSQLConnector.prepare_primary_key
for target to implement for custom table primary key adaptation
edgarrmondragon
deleted the
2729-feat-extend-the-sql-connector-api-to-support-adapting-to-primary-key-changes
branch
October 22, 2024 17:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Closes #2729
📚 Documentation preview 📚: https://meltano-sdk--2730.org.readthedocs.build/en/2730/