Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added SQLConnector.prepare_primary_key for target to implement for custom table primary key adaptation #2730

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Oct 21, 2024

TODO:

  • Docs
  • Tests

Closes #2729


📚 Documentation preview 📚: https://meltano-sdk--2730.org.readthedocs.build/en/2730/

@edgarrmondragon edgarrmondragon added Needs Documentation Release Highlight Call this out in the release notes labels Oct 21, 2024
@edgarrmondragon edgarrmondragon self-assigned this Oct 21, 2024
@edgarrmondragon edgarrmondragon added this to the v0.42.0 milestone Oct 21, 2024
Copy link

codspeed-hq bot commented Oct 21, 2024

CodSpeed Performance Report

Merging #2730 will not alter performance

Comparing 2729-feat-extend-the-sql-connector-api-to-support-adapting-to-primary-key-changes (df73e05) with main (9231412)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.71%. Comparing base (9231412) to head (df73e05).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2730   +/-   ##
=======================================
  Coverage   90.70%   90.71%           
=======================================
  Files          62       62           
  Lines        5016     5021    +5     
  Branches      641      641           
=======================================
+ Hits         4550     4555    +5     
  Misses        325      325           
  Partials      141      141           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the 2729-feat-extend-the-sql-connector-api-to-support-adapting-to-primary-key-changes branch from 3fe8ed0 to 4dab2f3 Compare October 21, 2024 18:26
@edgarrmondragon edgarrmondragon changed the title feat: Added SQLConnector.prepare_primary_key feat: Added SQLConnector.prepare_primary_key for target to implement for custom table primary Key adaptation Oct 22, 2024
@edgarrmondragon edgarrmondragon changed the title feat: Added SQLConnector.prepare_primary_key for target to implement for custom table primary Key adaptation feat: Added SQLConnector.prepare_primary_key for target to implement for custom table primary key adaptation Oct 22, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 22, 2024 17:40
@edgarrmondragon edgarrmondragon merged commit 9004c41 into main Oct 22, 2024
39 of 40 checks passed
@edgarrmondragon edgarrmondragon deleted the 2729-feat-extend-the-sql-connector-api-to-support-adapting-to-primary-key-changes branch October 22, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Documentation Release Highlight Call this out in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Extend the SQL connector API to support adapting to primary key changes
1 participant