Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Targets now emit record count from the built-in batch file processor #2703

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Targets now emit record count from the built-in batch file processor #2703

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d8e032
feat: Targets now emit record count from the built-in batch file proc…
edgarrmondragon Oct 4, 2024
8d7da14
Merge branch 'main' into edgarrmondragon/feat/records-batch-metric
edgarrmondragon Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions singer_sdk/sinks/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,7 @@ def process_batch_files(
}
else:
context = {"records": [deserialize_json(line) for line in file]}
self.record_counter_metric.increment(len(context["records"]))
self.process_batch(context)
elif (
importlib.util.find_spec("pyarrow")
Expand All @@ -765,6 +766,7 @@ def process_batch_files(
):
table = pq.read_table(file)
context = {"records": table.to_pylist()}
self.record_counter_metric.increment(len(context["records"]))
self.process_batch(context)
else:
msg = f"Unsupported batch encoding format: {encoding.format}"
Expand Down